(ci): replace archived actions-rs actions - #324
Merged
Conversation
Signed-off-by: krisztianfekete <git@krisztianfekete.org>
Member
|
The GitHub Actions docs seem to indicate we could use But this seems fine. |
SuperQ
approved these changes
Aug 3, 2026
Collaborator
Author
Yeah, good point, that would work too. Went with Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions-rs/toolchainandactions-rs/cargoare both archived and still onnode12, so dependabot keeps opening PRs to bump it, see #318.This PR replaces them with
dtolnay/rust-toolchain, which is already pinned at the same SHA in the cross-compile job, so no new dependency.All six cargo commands are unchanged,
profile: minimal/override: trueare what dtolnay does by default, andrustup component addfolds intocomponents:.Also dropped the protoc install from the Rustfmt job, since
cargo fmtnever builds anything.Job names are untouched so the checks report exactly as before. Only downside: we losethe inline error annotations
actions-rs/cargogave us, but errors are still in the logs.Closes #318.